PakhomovAlexander commented on PR #7777:
URL: https://github.com/apache/ignite-3/pull/7777#issuecomment-4178741807
## Code Review
Overall this is a solid, well-structured change. Two suggestions worth
addressing:
### 1. Unknown `--*` arguments are silently swallowed
In the Linux `parse_args`, any unrecognized argument (e.g., a typo like
`--nde-name`) is silently shifted away without any feedback. This makes
misconfiguration hard to debug. Consider emitting a warning for unrecognized
`--*` flags:
```sh
--*)
echo "Warning: unknown option '$1'" >&2
;;
```
Same applies to the Windows `:parseArgs` — unrecognized `--*` args silently
fall through to `shift`.
### 2. No `--help` flag
The script now accepts 5 new CLI flags (`--node-name`, `--work-dir`,
`--log-dir`, `--config`, `--extra-classpath`) but provides no usage message. A
`--help` / `-h` case in the parser printing available options would be valuable
for discoverability, especially since these flags don't appear to be documented
anywhere else in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
