ascherbakoff commented on code in PR #7799:
URL: https://github.com/apache/ignite-3/pull/7799#discussion_r3058342802
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/exception/ReplicationException.java:
##########
@@ -23,13 +23,11 @@
import org.apache.ignite.internal.lang.IgniteInternalException;
import org.apache.ignite.internal.replicator.ReplicationGroupId;
import org.apache.ignite.tx.RetriableReplicaRequestException;
-import org.apache.ignite.tx.RetriableTransactionException;
/**
* The exception is thrown when some issue happened during a replication.
*/
-public class ReplicationException extends IgniteInternalException implements
RetriableTransactionException,
- RetriableReplicaRequestException {
+public class ReplicationException extends IgniteInternalException implements
RetriableReplicaRequestException {
Review Comment:
I'm pretty sure in opposite: not any ReplicationException derived class is
retriable.
I've discovered this by unifying retry logic between explicit and implicit
transactions, which I believe should be the same:
```
private static boolean exceptionAllowsImplicitTxRetry(Throwable e) {
return ExceptionUtils.hasCause(e,
RetriableTransactionException.class);
}
```
I've observed some tests failing due to unexpected retries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
