JAkutenshi commented on code in PR #7988:
URL: https://github.com/apache/ignite-3/pull/7988#discussion_r3092106964
##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -4127,6 +4143,39 @@ private Future<?>
startChangePeersAndLearnersThread(ChangeArg arg) {
});
}
+ private void changePeersAndLearnersWithRetry(Configuration conf, long
timeoutMillis) throws InterruptedException {
+ Status lastStatus = null;
+ long deadlineNanos = System.nanoTime() +
TimeUnit.MILLISECONDS.toNanos(timeoutMillis);
+
+ while (System.nanoTime() < deadlineNanos) {
Review Comment:
Why should we retry and why we aren't expecting ok status exactly from the
first try?
##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -3055,7 +3068,8 @@ public void testNodeBlockedTimeoutNow() throws Exception {
Thread.sleep(30_000);
Review Comment:
Should we remove this and make timeout below equals to 30s?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
