JAkutenshi commented on code in PR #7988:
URL: https://github.com/apache/ignite-3/pull/7988#discussion_r3092346509
##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -4127,6 +4143,39 @@ private Future<?>
startChangePeersAndLearnersThread(ChangeArg arg) {
});
}
+ private void changePeersAndLearnersWithRetry(Configuration conf, long
timeoutMillis) throws InterruptedException {
+ Status lastStatus = null;
+ long deadlineNanos = System.nanoTime() +
TimeUnit.MILLISECONDS.toNanos(timeoutMillis);
+
+ while (System.nanoTime() < deadlineNanos) {
Review Comment:
Why raft layer may be non-stable if we got a leader already?
Moreover:
>The test was flaky here
Strange: the ticket is about `testJoinNodes` and it doesn't call the new
method. Do you mean that other fixed in this PR are flaky too but with the
reason of change peers instability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
