animovscw commented on code in PR #12982:
URL: https://github.com/apache/ignite/pull/12982#discussion_r3152334033
##########
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/BinaryContext.java:
##########
@@ -490,7 +490,8 @@ private static Iterable<String> classesInPackage(String
pkgName) {
for (File file : pkgDir.listFiles()) {
String fileName = file.getName();
- if (file.isFile() &&
fileName.toLowerCase().endsWith(".class"))
+ if (file.isFile() &&
fileName.toLowerCase().endsWith(".class")
+ && !fileName.equals("package-info.class"))
Review Comment:
Plugin update revealed that there was a defect in `BinaryContext` .
After the version was upgraded package-info.class became physically present
in the package directory on the disk. The method picked it up as a regular
class and added it to the list for registration as a binary type.
Logs:
https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_BinaryObjects/9015329?buildTab=overview
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
