anton-vinogradov commented on code in PR #13265:
URL: https://github.com/apache/ignite/pull/13265#discussion_r3476166087


##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/ContinuousQueryMarshallerTest.java:
##########
@@ -83,6 +83,8 @@ private void check(String node1Name, String node2Name) throws 
Exception {
 
         final Ignite node2 = "client".equals(node2Name) ? 
startClientGrid(node2Name) : startGrid(node2Name);
 
+        awaitPartitionMapExchange();

Review Comment:
   Optional nit: a one-line note on *why* the wait is here would protect it 
from being removed during a future "cleanup", since the call looks redundant 
out of context. Up to you — most of the other `awaitPartitionMapExchange()` 
calls in this package aren't commented either.
   
   ```suggestion
           // Wait for rebalance to finish so the initial scan query observes 
all pre-loaded entries.
           awaitPartitionMapExchange();
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to