anton-vinogradov commented on code in PR #13265:
URL: https://github.com/apache/ignite/pull/13265#discussion_r3480716668
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/ContinuousQueryMarshallerTest.java:
##########
@@ -83,6 +83,8 @@ private void check(String node1Name, String node2Name) throws
Exception {
final Ignite node2 = "client".equals(node2Name) ?
startClientGrid(node2Name) : startGrid(node2Name);
+ awaitPartitionMapExchange();
Review Comment:
Compromise on the earlier comment thread: keep the WHY (so the call survives
a future "cleanup"), while addressing both of your objections — it doesn't
restate the method name, and it says "stable topology" instead of the narrower
"rebalance".
```suggestion
// Initial scan must observe all pre-loaded entries, so run it only
on a stable topology.
awaitPartitionMapExchange();
```
Non-blocking — fine to merge without it if you'd rather keep the line bare.
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/query/continuous/ContinuousQueryMarshallerTest.java:
##########
@@ -83,6 +83,8 @@ private void check(String node1Name, String node2Name) throws
Exception {
final Ignite node2 = "client".equals(node2Name) ?
startClientGrid(node2Name) : startGrid(node2Name);
+ awaitPartitionMapExchange();
Review Comment:
Compromise on the earlier comment thread: keep the WHY (so the call survives
a future "cleanup"), while addressing both of your objections — it doesn't
restate the method name, and it says "stable topology" instead of the narrower
"rebalance".
```suggestion
// Initial scan must observe all pre-loaded entries, so run it only
on a stable topology.
awaitPartitionMapExchange();
```
Non-blocking — fine to merge without it if you'd rather keep the line bare.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
