anton-vinogradov commented on PR #358:
URL:
https://github.com/apache/ignite-extensions/pull/358#issuecomment-4893182600
Agreed. The custom runner existed only to keep the old 4-parameter test
names, but since (clientType, atomicity) is now encoded in the concrete class
name anyway, it is not worth the extra machinery.
Fixed in 73502305: `ParamsSlice`/`ParamsSliceRunner` removed, concrete
classes fix `clientType`/`atomicity` in constructors, `@Parameters` reduced to
`mode={0}, backupCnt={1}`.
Verified: compilation with checkstyle profile, each concrete class still
expands to the same 3 (mode, backupCnt) combinations, smoke run of
`CdcIgniteToIgniteReplicationThinClientAtomicTest#testActivePassiveReplication*`
is green (9/9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
