shishkovilja commented on code in PR #358:
URL: https://github.com/apache/ignite-extensions/pull/358#discussion_r3529382206
##########
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/AbstractReplicationTest.java:
##########
@@ -99,38 +98,38 @@
/** */
@RunWith(Parameterized.class)
public abstract class AbstractReplicationTest extends GridCommonAbstractTest {
- /** Client type to connect to a destination cluster. */
- @Parameterized.Parameter
- public ClientType clientType;
+ /** Client type to connect to a destination cluster. Fixed by the concrete
subclass constructor. */
Review Comment:
```suggestion
/** Client type to connect to a destination cluster. Initialized in the
concrete subclass constructor. */
```
##########
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/AbstractReplicationTest.java:
##########
@@ -99,38 +98,38 @@
/** */
@RunWith(Parameterized.class)
public abstract class AbstractReplicationTest extends GridCommonAbstractTest {
- /** Client type to connect to a destination cluster. */
- @Parameterized.Parameter
- public ClientType clientType;
+ /** Client type to connect to a destination cluster. Fixed by the concrete
subclass constructor. */
+ protected ClientType clientType;
- /** Cache atomicity mode. */
- @Parameterized.Parameter(1)
- public CacheAtomicityMode atomicity;
+ /** Cache atomicity mode. Fixed by the concrete subclass constructor. */
Review Comment:
```suggestion
/** Cache atomicity mode. Initialized in the concrete subclass
constructor. */
```
##########
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/AbstractReplicationTest.java:
##########
@@ -99,38 +98,38 @@
/** */
@RunWith(Parameterized.class)
public abstract class AbstractReplicationTest extends GridCommonAbstractTest {
- /** Client type to connect to a destination cluster. */
- @Parameterized.Parameter
- public ClientType clientType;
+ /** Client type to connect to a destination cluster. Fixed by the concrete
subclass constructor. */
+ protected ClientType clientType;
- /** Cache atomicity mode. */
- @Parameterized.Parameter(1)
- public CacheAtomicityMode atomicity;
+ /** Cache atomicity mode. Fixed by the concrete subclass constructor. */
+ protected CacheAtomicityMode atomicity;
/** Cache replication mode. */
- @Parameterized.Parameter(2)
+ @Parameterized.Parameter
public CacheMode mode;
/** */
- @Parameterized.Parameter(3)
+ @Parameterized.Parameter(1)
public int backups;
- /** @return Test parameters. */
- @Parameterized.Parameters(name = "clientType={0}, atomicity={1}, mode={2},
backupCnt={3}")
- public static Collection<?> parameters() {
+ /**
+ * Concrete subclasses fix {@code clientType} and {@code atomicity} in
constructors and run a single slice of
Review Comment:
Lets keep original javadoc, because `clientType` and `atomicity` fields
already have notes about initialization in their javadocs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
