wernerdv commented on PR #13184:
URL: https://github.com/apache/ignite/pull/13184#issuecomment-4992529723

   > ```
   > Step 5/11 : COPY apache-ignite* apache-ignite
   > When using COPY with more than one source file, the destination must be a 
directory and end with a /
   > 
   > Error during Docker image build
   > ```
   > 
   > Fix step `COPY apache-ignite* apache-ignite` for x86_64
   > 
   > Could we build the Docker image using HEAD instead of a specific pinned 
commit?
   > 
   > Currently, to build an older Ignite version, I have to manually modify 
step 5 of the Dockerfile directly on that older commit. Using HEAD would make 
this process dynamic and much simpler.
   
   I've addressed both points in build_docker_image.sh:
     
   1. COPY directive fix: The script now automatically patches all Dockerfiles 
(appending / to the destination of COPY apache-ignite* apache-ignite) right 
before building the Docker image.
   This patch is applied dynamically and automatically reverted after the 
script finishes, so you no longer need to manually modify the Dockerfile on 
older commits.
   
   2. Using HEAD: The script already supports building from HEAD out of the 
box. 
   If you run it without passing a specific commit hash 
(./build_docker_image.sh), it will use the latest commit (git rev-parse HEAD) 
to build and tag the Docker image.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to