alex-plekhanov commented on code in PR #13407:
URL: https://github.com/apache/ignite/pull/13407#discussion_r3675298409
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/CollectNode.java:
##########
@@ -114,6 +114,11 @@ public static <Row> CollectNode<Row>
createCountCollector(ExecutionContext<Row>
if (waiting == 0)
source().request(waiting = IN_BUFFER_SIZE);
+ else if (waiting < 0) {
Review Comment:
Becouse we must keep invariant: "end downstream only if any rows is
requested". If we request initially 1 row, push that row on "end()", we can't
futher end downstream, since no rows more requested and it can lead to
assertions. This case is shown in the new CollectIntegrationTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
