alex-plekhanov commented on code in PR #13407:
URL: https://github.com/apache/ignite/pull/13407#discussion_r3675364864
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/CorrelatedNestedLoopJoinNode.java:
##########
@@ -282,6 +282,8 @@ private void onRequest() throws Exception {
break;
case END:
+ requested = 0;
Review Comment:
Yes, new tests only cover CollectNode and SortAggregateNode changes. Changes
to CNLJ and SortNode are made to be consistent with other code. We have a lot
of nodes with:
```
requested = 0;
downstream().end();
```
Sequential calls. These 4 nodes are only nodes with different logic. Change
in SortNode it's not a bugfix, it's just code consistency, but CNLJ without
`requested = 0` can lead to the same problems as CollectNode and
SortAggregateNode. I think it's possible to write reproducer for CNLJ, but
maybe 2 tests is enoght to prove that `requested = 0` should always be placed
before `downstream().end()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
