zstan commented on code in PR #13311:
URL: https://github.com/apache/ignite/pull/13311#discussion_r3709626772
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/LimitOffsetIntegrationTest.java:
##########
@@ -101,40 +98,6 @@ public void testNestedLimitOffsetWithUnion() {
).returns(2).returns(4).check();
}
- /** Tests correctness of fetch / offset params. */
- @Test
- public void testInvalidLimitOffset() {
- String bigInt = BigDecimal.valueOf(10000000000L).toString();
-
- assertThrows("SELECT * FROM TEST_REPL OFFSET " + bigInt + " ROWS",
- SqlValidatorException.class, "Illegal value of offset");
-
- assertThrows("SELECT * FROM TEST_REPL FETCH FIRST " + bigInt + " ROWS
ONLY",
- SqlValidatorException.class, "Illegal value of fetch / limit");
-
- assertThrows("SELECT * FROM TEST_REPL LIMIT " + bigInt,
- SqlValidatorException.class, "Illegal value of fetch / limit");
-
- assertThrows("SELECT * FROM TEST_REPL OFFSET -1 ROWS FETCH FIRST -1
ROWS ONLY",
- IgniteSQLException.class, null);
-
- assertThrows("SELECT * FROM TEST_REPL OFFSET -1 ROWS",
- IgniteSQLException.class, null);
-
- assertThrows("SELECT * FROM TEST_REPL OFFSET 2+1 ROWS",
- IgniteSQLException.class, null);
-
- // Check with parameters
- assertThrows("SELECT * FROM TEST_REPL OFFSET ? ROWS FETCH FIRST ? ROWS
ONLY",
- SqlValidatorException.class, "Illegal value of fetch / limit", -1,
-1);
-
- assertThrows("SELECT * FROM TEST_REPL OFFSET ? ROWS",
- SqlValidatorException.class, "Illegal value of offset", -1);
-
- assertThrows("SELECT * FROM TEST_REPL FETCH FIRST ? ROWS ONLY",
- SqlValidatorException.class, "Illegal value of fetch / limit", -1);
Review Comment:
partially revert, other part is a covered by DynamicParametersPlannerTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
