tkalkirill commented on code in PR #13311:
URL: https://github.com/apache/ignite/pull/13311#discussion_r3712972037
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/LogicalRelImplementor.java:
##########
@@ -1050,4 +1054,33 @@ private ScanStorageNode<Row> createStorageScan(
otherColMapping
);
}
+
+ /** */
+ private long validateAndGetFetchOffsetParams(RexNode node, String op) {
+ Supplier<Object> scalar = expressionFactory.execute(node);
+ Object param = scalar.get();
+
+ if (!(param instanceof Number)) {
+ String actual = param == null ? "null" :
param.getClass().getSimpleName();
+ throw new
IgniteSQLException(IgniteResource.INSTANCE.incorrectDynamicParameterType("BIGINT",
actual).str(),
Review Comment:
To do it right, currently, you can pass any number as a parameter, yet for
some reason, only the BIGINT is mentioned here; I don't understand that. What
will the metadata contain for these parameters?
We could do it the way it is currently implemented in Calcite - DECIMAL, and
update the metadata as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
