zstan commented on code in PR #13375:
URL: https://github.com/apache/ignite/pull/13375#discussion_r3735571053


##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/IgniteMath.java:
##########
@@ -411,7 +412,7 @@ else if (x instanceof Float) {
 
     /** */
     private static double extendToRound(double x) {
-        return x < 0.0d ? x - 0.5d : x + 0.5d;
+        return round(x).doubleValue();

Review Comment:
   I remove all four usages of this func and PlannerTestSuite and 
IntegrationTestSuite are passed locally, 
   this are failed:
   ```
   test_floor_ceil.test
   test_trigo.test
   ```
   but seems it\`s expected and need to be also fixed, wdyt ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to