tkalkirill commented on code in PR #13375:
URL: https://github.com/apache/ignite/pull/13375#discussion_r3735586961
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/LimitOffsetIntegrationTest.java:
##########
@@ -121,10 +122,29 @@ public void testInvalidLimitOffset() {
assertThrows("SELECT * FROM TEST_REPL OFFSET -1 ROWS",
IgniteSQLException.class, null);
+ assertThrowsSqlException("SELECT * FROM TEST_REPL OFFSET -1.5 ROWS",
null);
+
+ assertThrowsSqlException("SELECT * FROM TEST_REPL OFFSET -0.5 ROWS",
null);
+
assertThrows("SELECT * FROM TEST_REPL OFFSET 2+1 ROWS",
IgniteSQLException.class, null);
}
+ /** */
+ @Test
+ public void testFractionalLimitOffset() throws Exception {
Review Comment:
These tests cover different execution paths. This test checks fractional
literals and the `SqlLiteral` validation path, while
`DynamicParametersIntegrationTest` checks dynamic parameters and their runtime
conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
