Vladsz83 commented on code in PR #13450:
URL: https://github.com/apache/ignite/pull/13450#discussion_r3759661783
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java:
##########
@@ -108,16 +107,12 @@ public class TcpDiscoveryNode extends
GridMetadataAwareAdapter implements Ignite
/** Node metrics. */
@GridToStringExclude
- volatile ClusterMetrics metrics;
-
- /** Node metrics message. */
- @GridToStringExclude
@Order(6)
- volatile NodeMetricsMessage metricsMsg;
+ volatile ClusterMetricsSnapshot clusterMetricsSnapshot;
/** Node cache metrics. */
@GridToStringExclude
- private volatile Map<Integer, CacheMetrics> cacheMetrics;
+ private volatile Map<Integer, CacheMetrics> cacheMetricsSnapshot;
Review Comment:
Is like the cluster metrics. Wierd behavior. There is a metric provider. But
we cache metrics sometimes. Unclear. That's why iI raised IGNITE-28965
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/internal/TcpDiscoveryNode.java:
##########
@@ -315,40 +295,31 @@ public Map<String, Object> getAttributes() {
/** {@inheritDoc} */
@Override public ClusterMetrics metrics() {
- if (metricsProvider != null) {
- ClusterMetrics metrics0 = metricsProvider.metrics();
+ assert clusterMetricsSnapshot != null || metricsProvider != null;
Review Comment:
Passed test guarantee. Asserts are not for prod. They are for developers,
tests. Old metrics are about to get deprecated. I think assert is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
