tkalkirill commented on code in PR #13467: URL: https://github.com/apache/ignite/pull/13467#discussion_r3766183044
########## modules/calcite/src/test/sql/order/test_limit.test: ########## @@ -28,12 +28,14 @@ query I SELECT a FROM test ORDER BY a LIMIT 1.5 ---- 11 +12 Review Comment: `RoundingMode.DOWN` was introduced only recently by IGNITE-28896 and has not been included in any Ignite release yet. Before that change, pagination values were converted through `IgniteMath.convertToLongExact(Number)`, whose rounding mode is `HALF_UP`. Therefore, this patch does not change any released public API behavior. It restores the previous rounding behavior as the default and makes it configurable for plugins. `IgniteSqlPaginationPolicy` itself is also located in an internal package. I agree that matching Oracle/Ignite 3 by default is a design choice worth confirming, but this is not a backward compatibility issue with a released version. Since IGNITE-28896 and this follow-up belong to the same unreleased development cycle, I don't think a dev-list discussion is required unless we want a broader agreement on the default dialect behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
