tkalkirill commented on code in PR #13467:
URL: https://github.com/apache/ignite/pull/13467#discussion_r3824325692
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/AbstractPlannerTest.java:
##########
@@ -229,10 +230,13 @@ private PlanningContext plannerCtx(
Collection<IgniteSchema> schemas,
@Nullable RelOptListener planLsnr,
Collection<Object> params,
- Collection<String> disabledRules
+ Collection<String> disabledRules,
+ @Nullable Context additionalCtx
) {
+ Context parentCtx = Contexts.of(baseQueryContext(schemas), planLsnr);
Review Comment:
Unfortunately, this does not work when `additionalCtx` is already a
`Context`. `Contexts.of(Object...)` wraps it as a regular object and does not
delegate `unwrap` calls to it. Therefore, `IgniteSqlPaginationPolicy` cannot be
resolved and the test fails. `Contexts.chain` is required here to compose
contexts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
