wernerdv commented on code in PR #13540:
URL: https://github.com/apache/ignite/pull/13540#discussion_r3986595162
##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/testframework/testcontainers/IgniteClusterContainer.java:
##########
@@ -30,21 +31,52 @@ public class IgniteClusterContainer implements Startable {
private final List<IgniteContainer> containers;
/** Network. */
- private final Network net = Network.newNetwork();
+ private final Network net;
+
+ /** Image name. */
+ private final String imageName;
+
+ /** Consistent ID's. */
+ private final List<String> consistentIds;
/**
* @param imageName Image name.
* @param consistentIds Consistent ID's.
*/
- public IgniteClusterContainer(String imageName, List<String>
consistentIds) throws Exception {
+ public IgniteClusterContainer(String imageName, List<String>
consistentIds) {
+ this.imageName = imageName;
+ this.consistentIds = consistentIds;
+
+ net = Network.newNetwork();
containers = new ArrayList<>(consistentIds.size());
+ }
+ /**
+ * @param imageName Image name.
+ * @param net Shared test network the container must be attached to.
+ * @param consistentIds Consistent ID's.
+ * @param idx Node index.
+ * @return The node container.
+ */
+ protected IgniteContainer container(String imageName, Network net,
List<String> consistentIds, int idx) throws Exception {
+ return new IgniteContainer(imageName, net, "node" + (1 + idx),
consistentIds.get(idx), idx);
+ }
+
+ /** Builds the node containers. */
+ protected void initContainers() throws Exception {
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
