wernerdv commented on code in PR #13540:
URL: https://github.com/apache/ignite/pull/13540#discussion_r4025370175
##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/testframework/testcontainers/IgniteContainer.java:
##########
@@ -383,77 +398,194 @@ private String execControl(String... cmd) {
return result.getStdout();
}
- /** @return Jar with {@link #TEST_CLASSES}, built once and reused for all
containers. */
- private static File testClassesJar() throws IOException {
- File jar = testClassesJar;
+ /**
+ * Builds the {@code control.sh} command line to be executed inside the
container.
+ *
+ * @param cmd Control utility arguments (e.g. {@code --set-state ACTIVE
--yes}).
+ * @return Full command whose first element is the absolute path to {@code
control.sh}, followed by {@code cmd}.
+ */
+ protected String[] command(String... cmd) {
+ String[] fullCmd = new String[cmd.length + 1];
+
+ fullCmd[0] = rootDir + "bin/control.sh";
+
+ System.arraycopy(cmd, 0, fullCmd, 1, cmd.length);
+
+ return fullCmd;
+ }
Review Comment:
You're right — there's no current need for execControl() to be a separate
extension point.
I've reverted execControl() back to private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
