zstan commented on code in PR #13389:
URL: https://github.com/apache/ignite/pull/13389#discussion_r4026163454
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/UncollectPlannerTest.java:
##########
@@ -112,11 +112,7 @@ public void testHashTableAndUnnestJoin() throws Exception {
assertPlan(sql, publicSchema, nodeOrAnyChild(isInstanceOf(Join.class)
.and(nodeOrAnyChild(isInstanceOf(IgniteExchange.class).negate())
.and(nodeOrAnyChild(isTableScan("hash_tbl"))))
- .and(nodeOrAnyChild(isInstanceOf(IgniteTrimExchange.class))
- .and(nodeOrAnyChild(isInstanceOf(IgniteUncollect.class)
- .and(hasDistribution(broadcast()))
- ))
- )
+ .and(nodeOrAnyChild(isInstanceOf(IgniteUncollect.class)))
Review Comment:
current plan:
```
IgniteHashJoin(condition=[=($0, $2)], joinType=[inner], variablesSet=[[]]):
rowcount = 1.0, cumulative cost = IgniteCost [rowCount=1000007.0,
cpu=1000016.0, memory=30.4, io=0.0, network=4000000.0]
IgniteExchange(distribution=[single]): rowcount = 500000.0
IgniteTableScan(table=[[PUBLIC, HASH_TBL]]): rowcount = 500000.0
IgniteUncollect
IgniteProject(EXPR$0=[ARRAY(1, 2, 3)])
IgniteValues(tuples=[[{ 0 }]])
```
master branch plan:
```
IgniteProject(ID=[$1], NAME=[$2], EXPR$0=[$0]): rowcount = 4.0, cumulative
cost = IgniteCost [rowCount=2300018.0, cpu=9200030.0, memory=0.0, io=0.0,
network=48.0], id = 2654
IgniteExchange(distribution=[single]):
IgniteCorrelatedNestedLoopJoin(condition=[=($1, $0)], joinType=[inner],
variablesSet=[[$cor0]], variablesSet=[[0]], correlationVariables=[[$cor0]]):
rowcount = 4.0
IgniteTrimExchange(distribution=[hash[0]])
IgniteUncollect
IgniteProject(EXPR$0=[ARRAY(1, 2, 3)])
IgniteValues(tuples=[[{ 0 }]])
IgniteTableScan(table=[[PUBLIC, HASH_TBL]], filters=[=($t0,
$cor0.EXPR$0)]): rowcount = 75000.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
