zstan commented on code in PR #13389:
URL: https://github.com/apache/ignite/pull/13389#discussion_r4358888934
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/IgniteMdColumnOrigins.java:
##########
@@ -281,7 +288,19 @@ public class IgniteMdColumnOrigins implements
MetadataHandler<BuiltInMetadata.Co
return res;
}
- return
Collections.singleton(rel.columnOriginsByRelLocalRef(iOutputColumn));
Review Comment:
`indexOf` is not identical to `toArray()[colIdx]` but ok, I fix it
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/CalciteQueryProcessor.java:
##########
@@ -145,8 +144,6 @@ public class CalciteQueryProcessor extends
GridProcessorAdapter implements Query
// See Apache Calcite ticket for more information, assertion is
incorrect.
// FRAMEWORK_CONFIG initialize SqlToRelConverter class. Assertions
should be disabled before class initialization.
SqlToRelConverter.class.getClassLoader().setClassAssertionStatus(SqlToRelConverter.class.getName(),
false);
- // TODO Workaround for
https://issues.apache.org/jira/browse/CALCITE-5421 and
https://issues.apache.org/jira/browse/CALCITE-7034
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
