XianReallyHot-ZZH commented on PR #13719: URL: https://github.com/apache/ignite/pull/13719#issuecomment-6464476127
Thanks for running the TeamCity builds! The C++ tests have been updated to match the propagated H2 error codes (commit edac42216c): - **odbc-test `TestSyntaxError`**: the query referenced an unknown column (`fasf`), which now resolves to `COLUMN_NOT_FOUND` (H2 42122) and is reported with SQLSTATE `42S22` instead of `42000`. The test now uses a statement with a genuine syntax error (missing `)`) so it keeps covering `42000`, and the original query moved to a new `TestColumnNotFound` case asserting `42S22` — mirroring the existing `TestTableNotFound` / `TestIndexNotFound` cases. - **thin-client-test `TestSqlStateOnErrors`**: `select * from "UnknownCache".UNKNOWN_TABLE` now resolves to `SCHEMA_NOT_FOUND` (H2 90079), whose SQLSTATE maps to `50000` through `IgniteQueryErrorCode#codeToSqlState`. This matches the pre-existing behavior of the schema-validation path (a query with a missing schema produced `SCHEMA_NOT_FOUND` → `50000` before this change as well). If you think `SCHEMA_NOT_FOUND` should map to `42000` there instead, I can add it to `codeToSqlState` — kept as-is for now to avoid changing the existing schema paths. Also added an `INSERT` with an unknown column to `IgniteCacheSqlQueryErrorSelfTest#testParseErrorCodes` to pin the Java-side code (`COLUMN_NOT_FOUND`) that the ODBC test now relies on. Verified at the H2 level (1.4.197 patched): INSERT with unknown column → 42122, unknown schema → 90079, unknown table → 42102, the new syntax-error statement → 42001. The full `IgniteCacheSqlQueryErrorSelfTest` (10 tests, including the new assertion) passes locally on JDK 17. Could you please re-run the C++ TeamCity suites when you have a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
