XianReallyHot-ZZH commented on PR #13719:
URL: https://github.com/apache/ignite/pull/13719#issuecomment-6512446063
While re-checking the branch I found one more gap in the ODBC path: with the
propagated codes, a query against a missing schema (e.g. `SELECT * FROM
"NoSuchSchema".UNKNOWN_TABLE`) now reaches the ODBC driver as
`SCHEMA_NOT_FOUND` (3015), which had no case in `ResponseStatusToSqlState` — it
fell through to the generic `HY000` where the client used to see `42000`.
Commit `$\{COMMIT\}: maps it to the standard invalid-schema-name SQLSTATE
`3F000`, adds a `TestSchemaNotFound` case to the ODBC error suite, and pins the
`COLUMN_ALREADY_EXISTS` mapping (duplicate column in an INSERT column list →
`42S21`) with a Java-side assertion (`testParseErrorCodes`, 10/10 green locally
on JDK 17).
Two small test cleanups ride along: a stale comment + `sizeof()` → `SQL_NTS`
in `TestErrorMessage`, and a dead `boost/regex` include in `errors_test.cpp`.
The branch now carries two commits since your last run (af818870 + 5d049d10)
— same re-run request stands. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]