maksaska commented on code in PR #13627:
URL: https://github.com/apache/ignite/pull/13627#discussion_r4540924148


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java:
##########
@@ -524,6 +526,18 @@ public void onCoordinatorInitialized() {
      * @param cache Cache.
      */
     public void onLocalJoin(DiscoveryEvent evt, DiscoCache cache) {
+        IgniteFeatureManager features = 
cctx.kernalContext().rollingUpgrade().features();
+
+        boolean activationAhead = !cctx.kernalContext().clientNode()
+            && 
features.localVersionFeatures().contains(PART_STATE_FROM_OWNER_FEATURE)
+            && !features.isActive(PART_STATE_FROM_OWNER_FEATURE);
+
+        // On activation every server resends its maps once: an owner that 
finished its last exchange before the
+        // activation didn't send its map, and the other nodes no longer write 
its state. A node that emulates an older
+        // version in tests lacks the feature, and listenActivation() requires 
it.
+        if (activationAhead)
+            features.listenActivation(PART_STATE_FROM_OWNER_FEATURE, 
this::scheduleResendPartitions);
+

Review Comment:
   Removed



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java:
##########
@@ -104,6 +104,7 @@
 import org.apache.ignite.internal.processors.metric.impl.BooleanMetricImpl;
 import org.apache.ignite.internal.processors.metric.impl.HistogramMetricImpl;
 import 
org.apache.ignite.internal.processors.query.schema.SchemaNodeLeaveExchangeWorkerTask;
+import 
org.apache.ignite.internal.processors.rollingupgrade.feature.IgniteFeatureManager;

Review Comment:
   Removed



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java:
##########
@@ -161,6 +162,7 @@
 import static 
org.apache.ignite.internal.processors.metric.GridMetricManager.PME_OPS_BLOCKED_DURATION;
 import static 
org.apache.ignite.internal.processors.metric.GridMetricManager.PME_OPS_BLOCKED_DURATION_HISTOGRAM;
 import static 
org.apache.ignite.internal.processors.metric.GridMetricManager.REBALANCED;
+import static 
org.apache.ignite.internal.processors.rollingupgrade.feature.CoreFeatureRegistry.PART_STATE_FROM_OWNER_FEATURE;

Review Comment:
   Removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to