alex-plekhanov commented on code in PR #13722:
URL: https://github.com/apache/ignite/pull/13722#discussion_r4630216854
##########
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/msg/GridH2QueryRequest.java:
##########
@@ -74,22 +74,9 @@ public class GridH2QueryRequest extends AbstractMessage
implements GridCacheQuer
*/
public static final int FLAG_LAZY = 1 << 5;
- /** */
+ /** Bit offset of the former data page scan flag. */
private static final int FLAG_DATA_PAGE_SCAN_SHIFT = 6;
Review Comment:
This fields is not used and there is no information left that DATA_PAGE_SCAN
requires 2 bits. Someone can introduce new flag and use, for example 7-th bit,
and RU compatibility will be broken. Maybe we should leave
FLAG_DATA_PAGE_SCAN_MASK and explicetely clear these bits (`flags &=
~FLAG_DATA_PAGE_SCAN_MASK`) to show that these bits should not be reused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]