quantranhong1999 commented on a change in pull request #534:
URL: https://github.com/apache/james-project/pull/534#discussion_r667277582



##########
File path: 
mailbox/api/src/main/java/org/apache/james/mailbox/MailboxManager.java
##########
@@ -324,6 +325,16 @@ public final int hashCode() {
      */
     Publisher<MessageId> search(MultimailboxesSearchQuery expression, 
MailboxSession session, long limit) throws MailboxException;
 
+    /**
+     *
+     * @param threadId
+     *          target Thread
+     * @param session
+     *          the context for this call, not null
+     * @return  a list of MessageId of messages belong to that Thread
+     */
+    Flux<MessageId> getThread(ThreadId threadId, MailboxSession session) 
throws MailboxException;

Review comment:
       At the moment, we just use searching for InMemory, we still need 
NaiveThreadIdGuessingAlgorithm for Cassandra and OpenJPA. And I would like to 
package related ThreadId APIs in ThreadIdGuessingAlgorithm.
   
   What about recoding MailboxManager::search in 
SearchThreadIdGuessingAlgorithm? (a little duplicated though, but solve above 
problem)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to