Arsnael commented on a change in pull request #534:
URL: https://github.com/apache/james-project/pull/534#discussion_r671077577
##########
File path:
mailbox/api/src/main/java/org/apache/james/mailbox/MailboxManager.java
##########
@@ -333,7 +333,7 @@ public final int hashCode() {
* the context for this call, not null
* @return a list of MessageId of messages belong to that Thread
*/
- Flux<MessageId> getThread(ThreadId threadId, MailboxSession session)
throws MailboxException;
+ Publisher<MessageId> getThread(ThreadId threadId, MailboxSession session)
throws MailboxException;
Review comment:
And yes there is other publisher methods still doing this too... we
should clean up a bit :)
##########
File path:
mailbox/api/src/main/java/org/apache/james/mailbox/MailboxManager.java
##########
@@ -333,7 +333,7 @@ public final int hashCode() {
* the context for this call, not null
* @return a list of MessageId of messages belong to that Thread
*/
- Flux<MessageId> getThread(ThreadId threadId, MailboxSession session)
throws MailboxException;
+ Publisher<MessageId> getThread(ThreadId threadId, MailboxSession session)
throws MailboxException;
Review comment:
I think those search methods were not reactive before and that throws
stayed in the api interface. You can remove it I think. If you look at the
current implementations of MailboxManager, they don't seem to throw it either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
