chibenwa commented on code in PR #1561:
URL: https://github.com/apache/james-project/pull/1561#discussion_r1233325318
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/json/EmailSubmissionSetSerializer.scala:
##########
@@ -69,12 +69,25 @@ class EmailSubmissionSetSerializer
@Inject()(messageIdFactory: MessageId.Factory
private implicit val emailSubmissionIdWrites: Writes[EmailSubmissionId] =
Json.valueWrites[EmailSubmissionId]
- private implicit val emailSubmissionAddresReads:
Reads[EmailSubmissionAddress] = Json.reads[EmailSubmissionAddress]
+ private implicit val parameterNameReads: Reads[ParameterName] =
Json.valueReads[ParameterName]
+ private implicit val parameterValueReads: Reads[ParameterValue] =
Json.valueReads[ParameterValue]
+ private implicit val parameterValueOptionReads:
Reads[Option[ParameterValue]] = {
+ case JsString(value) => JsSuccess(Some(ParameterValue(value)))
+ case _ => JsError("JsonPath objects are represented by JsonString")
+ }
+
+ private implicit val parametersReads: Reads[Map[ParameterName,
Option[ParameterValue]]] =
+ Reads.mapReads[ParameterName, Option[ParameterValue]](k =>
JsSuccess(ParameterName(k)))(parameterValueOptionReads)
+
+ private implicit val emailSubmissionAddresReads:
Reads[EmailSubmissionAddress] = {
Review Comment:
This comment is still not applied !!!
Do we really need to wait one month to fix a typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
