vttranlina commented on code in PR #1561:
URL: https://github.com/apache/james-project/pull/1561#discussion_r1234957540
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/Capability.scala:
##########
@@ -161,16 +164,42 @@ final case class EhloArg(value: String) extends AnyVal
final case class EhloArgs(values: List[EhloArg]) extends AnyVal
final case class SubmissionCapability(identifier: CapabilityIdentifier =
EMAIL_SUBMISSION,
- properties: SubmissionProperties =
SubmissionProperties()) extends Capability
+ properties: SubmissionProperties)
extends Capability
-case object SubmissionCapabilityFactory extends CapabilityFactory {
+case object SubmissionCapabilityFactory {
+ val maximumDelays = Duration.ofDays(1)
+}
+
+final case class SubmissionCapabilityFactory(clock: Clock, supportsDelaySends:
Boolean) extends CapabilityFactory {
override def id(): CapabilityIdentifier = EMAIL_SUBMISSION
- override def create(urlPrefixes: UrlPrefixes): Capability =
SubmissionCapability()
+ override def create(urlPrefixes: UrlPrefixes): Capability =
+ if (supportsDelaySends) {
+ advertiseDelaySendSupport
+ } else {
+ advertiseNoDelaySendSupport
+ }
+
+ private def advertiseDelaySendSupport = {
+ val now = LocalDateTime.now(clock).toInstant(ZoneOffset.UTC)
Review Comment:
clock.instant() is enough?
```
DateTimeFormatter.ISO_INSTANT.withZone(ZoneId.of("UTC")).format(clock.instant().plus(maximumDelays))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
