chibenwa commented on code in PR #1643:
URL: https://github.com/apache/james-project/pull/1643#discussion_r1260534397
##########
server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/mailet/filter/JMAPFilteringTest.java:
##########
@@ -725,19 +726,19 @@ void
mailDirectiveShouldSetLastMatchedRuleWhenMultipleRules(JMAPFilteringTestSys
Rule.builder()
.id(Rule.Id.of("1"))
.name("rule 1")
- .condition(Rule.Condition.of(SUBJECT, CONTAINS,
UNSCRAMBLED_SUBJECT))
+ .conditions(Arrays.asList(Rule.Condition.of(SUBJECT,
CONTAINS, UNSCRAMBLED_SUBJECT)))
Review Comment:
We can keep a convenience method to build a rule with a single condition and
avoid boiler plate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
