chibenwa commented on code in PR #1643:
URL: https://github.com/apache/james-project/pull/1643#discussion_r1261426848


##########
server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/mailet/filter/MailMatcher.java:
##########
@@ -63,7 +59,7 @@ public boolean match(Mail mail) {
                     case OR:
                         return 
mailMatchingConditions.stream().anyMatch(predicate);
                     default:
-                        return false;
+                        throw new Exception("this conditionCombiner case is 
not supported");

Review Comment:
   Let's improve the exception message: Which one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to