Arsnael commented on code in PR #1743:
URL: https://github.com/apache/james-project/pull/1743#discussion_r1360455388


##########
server/apps/memory-app/sample-configuration/logback.xml:
##########
@@ -52,29 +43,16 @@
                         <maxFileSize>100MB</maxFileSize>
                 </triggeringPolicy>
 
-                <encoder 
class="ch.qos.logback.core.encoder.LayoutWrappingEncoder">
-                        <layout 
class="ch.qos.logback.contrib.json.classic.JsonLayout">
-                                
<timestampFormat>yyyy-MM-dd'T'HH:mm:ss.SSSX</timestampFormat>
-                                
<timestampFormatTimezoneId>Etc/UTC</timestampFormatTimezoneId>
-
-                                <!-- Importance for handling multiple lines 
log -->
-                                <appendLineSeparator>true</appendLineSeparator>
-
-                                <jsonFormatter 
class="ch.qos.logback.contrib.jackson.JacksonJsonFormatter">
-                                        <prettyPrint>false</prettyPrint>
-                                </jsonFormatter>
-                        </layout>
+                <encoder>
+                        <pattern>%d{HH:mm:ss.SSS} [%-5level] %logger{15} - 
%msg%n%rEx</pattern>
+                        <immediateFlush>false</immediateFlush>

Review Comment:
   Why not removing directly the appender `LOG_FILE` as you seem to only get 
logs from the console now anyways/ :)



##########
server/apps/distributed-app/sample-configuration/logback.xml:
##########
@@ -33,41 +24,19 @@
                         <maxFileSize>100MB</maxFileSize>
                 </triggeringPolicy>
 
-                <encoder 
class="ch.qos.logback.core.encoder.LayoutWrappingEncoder">
-                        <layout 
class="ch.qos.logback.contrib.json.classic.JsonLayout">
-                                
<timestampFormat>yyyy-MM-dd'T'HH:mm:ss.SSSX</timestampFormat>
-                                
<timestampFormatTimezoneId>Etc/UTC</timestampFormatTimezoneId>
-
-                                <!-- Importance for handling multiple lines 
log -->
-                                <appendLineSeparator>true</appendLineSeparator>
-
-                                <jsonFormatter 
class="ch.qos.logback.contrib.jackson.JacksonJsonFormatter">
-                                        <prettyPrint>false</prettyPrint>
-                                </jsonFormatter>
-                        </layout>
+                <encoder>
+                        <pattern>%d{HH:mm:ss.SSS} [%-5level] %logger{15} - 
%msg%n%rEx</pattern>
+                        <immediateFlush>false</immediateFlush>

Review Comment:
   idem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to