Arsnael commented on code in PR #1743:
URL: https://github.com/apache/james-project/pull/1743#discussion_r1361437637


##########
server/apps/distributed-app/sample-configuration/logback.xml:
##########
@@ -11,32 +11,11 @@
                         <immediateFlush>false</immediateFlush>
                 </encoder>
         </appender>
-
-        <appender name="LOG_FILE" 
class="ch.qos.logback.core.rolling.RollingFileAppender">
-                <file>/logs/james.log</file>
-                <rollingPolicy 
class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
-                    
<fileNamePattern>/logs/james.%i.log.tar.gz</fileNamePattern>
-                    <minIndex>1</minIndex>
-                    <maxIndex>3</maxIndex>
-                </rollingPolicy>
-
-                <triggeringPolicy 
class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
-                    <maxFileSize>100MB</maxFileSize>
-                </triggeringPolicy>
-
-                <encoder>
-                        <pattern>%d{HH:mm:ss.SSS} [%-5level] %logger{15} - 
%msg%n%rEx</pattern>
-                        <immediateFlush>false</immediateFlush>
-                </encoder>
-        </appender>
-
         <root level="WARN">
                 <appender-ref ref="CONSOLE" />
-                <appender-ref ref="LOG_FILE" />
         </root>
 
         <logger name="org.apache.james" level="INFO" />
         <logger name="com.datastax.driver.core.QueryLogger.SLOW" level="DEBUG" 
/>
 
-
-</configuration>
+</configuration>

Review Comment:
   He is just removing the appender that was only  created for crowdsec but not 
needed anymore? surely we dont want to keep that right? :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to