Arsnael commented on code in PR #1743:
URL: https://github.com/apache/james-project/pull/1743#discussion_r1365057529


##########
protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractAuthProcessor.java:
##########
@@ -100,6 +100,7 @@ protected void doAuth(AuthenticationAttempt 
authenticationAttempt, ImapSession s
                     session.stopDetectingCommandInjection();
                 } catch (BadCredentialsException e) {
                     authFailure = true;
+                    LOGGER.info("User {} failed authentication", 
authenticationAttempt.getAuthenticationId().asString());

Review Comment:
   Not solved IMO and this log should not be merged, as it brings nothing than 
just making work some poc/demo... 
   
   I thought we were supposed to try to use audit trail logs (already in place) 
for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to