chibenwa commented on code in PR #2393:
URL: https://github.com/apache/james-project/pull/2393#discussion_r1735709020
##########
server/container/guice/mailet/src/main/java/org/apache/james/modules/server/MailetContainerModule.java:
##########
@@ -86,7 +86,7 @@ public class MailetContainerModule extends AbstractModule {
"transport",
All.class,
RemoveMimeHeader.class,
- pair ->
Arrays.asList(pair.getMailet().getMailetConfig().getInitParameter("name").split(",")).contains("bcc"),
+ pair ->
Arrays.asList(pair.getMailet().getMailetConfig().getInitParameter("name").toLowerCase().split(",")).contains("bcc"),
Review Comment:
Other stupid edge case question: do we handle the case where
RemoveMimeHeader do not have a "name" property decently?
IE we likely throw today an uggly non explicit NPE, it would be nice to
throw a contextualized with decent error message IllegalStateException, and
have a unit test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
