Arsnael commented on code in PR #2393:
URL: https://github.com/apache/james-project/pull/2393#discussion_r1735881521
##########
server/container/guice/mailet/src/main/java/org/apache/james/modules/server/MailetContainerModule.java:
##########
@@ -86,7 +86,7 @@ public class MailetContainerModule extends AbstractModule {
"transport",
All.class,
RemoveMimeHeader.class,
- pair ->
Arrays.asList(pair.getMailet().getMailetConfig().getInitParameter("name").split(",")).contains("bcc"),
+ pair ->
Arrays.asList(pair.getMailet().getMailetConfig().getInitParameter("name").toLowerCase().split(",")).contains("bcc"),
Review Comment:
Actually it does.
RemoveMimeHeader throws this in case of missing name property =>
https://github.com/apache/james-project/blob/master/mailet/standard/src/main/java/org/apache/james/transport/mailets/RemoveMimeHeader.java#L53
```
throw new MailetException("Invalid config. Please specify atleast one name");
```
And the test =>
https://github.com/apache/james-project/blob/master/mailet/standard/src/test/java/org/apache/james/transport/mailets/RemoveMimeHeaderTest.java#L212
I think it's ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
