quantranhong1999 commented on code in PR #2401:
URL: https://github.com/apache/james-project/pull/2401#discussion_r1749789952
##########
server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/IMAPServerFactory.java:
##########
@@ -76,16 +78,19 @@ protected IMAPServer
createServer(HierarchicalConfiguration<ImmutableNode> confi
protected List<AbstractConfigurableAsyncServer>
createServers(HierarchicalConfiguration<ImmutableNode> config) throws Exception
{
List<AbstractConfigurableAsyncServer> servers = new ArrayList<>();
List<HierarchicalConfiguration<ImmutableNode>> configs =
config.configurationsAt("imapserver");
-
+
for (HierarchicalConfiguration<ImmutableNode> serverConfig: configs) {
IMAPServer server = createServer(serverConfig);
server.setFileSystem(fileSystem);
server.configure(serverConfig);
servers.add(server);
}
+ imapServers = servers.stream().map(IMAPServer.class::cast).toList();
return servers;
-
}
+ public List<IMAPServer> getImapServers() {
Review Comment:
We can use
https://github.com/apache/james-project/blob/master/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/netty/AbstractServerFactory.java#L66
and filter by IMAP server type.
##########
server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/IMAPHealthCheck.java:
##########
@@ -0,0 +1,55 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information *
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the *
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the *
+ * specific language governing permissions and limitations *
+ * under the License. *
+ ****************************************************************/
+
+package org.apache.james.imapserver.netty;
+
+import jakarta.inject.Inject;
+
+import org.apache.james.core.healthcheck.ComponentName;
+import org.apache.james.core.healthcheck.HealthCheck;
+import org.apache.james.core.healthcheck.Result;
+
+import reactor.core.publisher.Mono;
+
+public class IMAPHealthCheck implements HealthCheck {
+ private static final ComponentName COMPONENT_NAME = new
ComponentName("Cassandra backend");
+
+ private final IMAPServerFactory imapServerFactory;
+
+ @Inject
+ public IMAPHealthCheck(IMAPServerFactory imapServerFactory) {
+ this.imapServerFactory = imapServerFactory;
+ }
+
+ @Override
+ public ComponentName componentName() {
+ return COMPONENT_NAME;
+ }
+
+ @Override
+ public Mono<Result> check() {
+ return Mono.fromCallable(() -> {
+ if
(imapServerFactory.getImapServers().stream().map(IMAPServer::getReactiveThrottler).anyMatch(ReactiveThrottler::isQueueFull))
{
Review Comment:
Can we extract method for this? and with better indent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
