chibenwa commented on code in PR #2401:
URL: https://github.com/apache/james-project/pull/2401#discussion_r1750105762
##########
server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/IMAPServerFactory.java:
##########
@@ -76,16 +78,19 @@ protected IMAPServer
createServer(HierarchicalConfiguration<ImmutableNode> confi
protected List<AbstractConfigurableAsyncServer>
createServers(HierarchicalConfiguration<ImmutableNode> config) throws Exception
{
List<AbstractConfigurableAsyncServer> servers = new ArrayList<>();
List<HierarchicalConfiguration<ImmutableNode>> configs =
config.configurationsAt("imapserver");
-
+
for (HierarchicalConfiguration<ImmutableNode> serverConfig: configs) {
IMAPServer server = createServer(serverConfig);
server.setFileSystem(fileSystem);
server.configure(serverConfig);
servers.add(server);
}
+ imapServers = servers.stream().map(IMAPServer.class::cast).toList();
return servers;
-
}
+ public List<IMAPServer> getImapServers() {
Review Comment:
BTW what prevent us from doing the cast within IMAPHealthCheck ?
This would prevent a change here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
