jeantil commented on code in PR #2904:
URL: https://github.com/apache/james-project/pull/2904#discussion_r2671095884
##########
server/blob/blob-s3/src/main/java/org/apache/james/blob/objectstorage/aws/BucketNameResolver.java:
##########
@@ -87,17 +87,15 @@ private BucketNameResolver(Optional<BucketName> namespace,
Optional<String> pref
BucketName resolve(BucketName bucketName) {
Preconditions.checkNotNull(bucketName);
- if (isNameSpace(bucketName)) {
- return bucketName;
- }
- return prefix
- .map(bucketPrefix -> BucketName.of(bucketPrefix +
bucketName.asString()))
- .orElse(bucketName);
+ return namespace.filter(any -> BucketName.DEFAULT.equals(bucketName))
Review Comment:
This now compares bucketname to the static `DEFAULT` ("default") value where
it used to be compared to the value of the namespace if present.
so if my namespace is `foo` and my prefix is `prod-`
`resolve("foo")` used to return `foo`
now it will return `prod-foo`
this is visible in the change line 213 in the test and I think it is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
