chibenwa commented on PR #2904: URL: https://github.com/apache/james-project/pull/2904#issuecomment-3723278722
Well, the object-store bucket is a S3 implementation detail And the James "default bucket" was always Bucket.DEFAULT. Having a "default bucket" that could artificially vary makes calling the blobstore more complex. `blobStroe.save(blobStore.defaultBucket(), xxx)` VS `blobStore.save(BucketName.DEFAULT, xxx)` And IMO the lines of code reductions proves this artifical concept actually created accidental complexity. Also the main issue I had was when trying to encode buckets in object name at the DAO level I needed to know the default bucket name which is a blobStore concept - not the same layer. This refactoring makes this trivial. And IMO is a pre-requisite for having S3BlobStoreDAO encoding James buckets as folders. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
