jeantil commented on code in PR #2902:
URL: https://github.com/apache/james-project/pull/2902#discussion_r2698881487
##########
mailbox/plugin/deleted-messages-vault/src/main/java/org/apache/james/vault/VaultConfiguration.java:
##########
@@ -31,32 +31,38 @@
import com.google.common.base.Preconditions;
public class VaultConfiguration {
+ public static final String DEFAULT_SINGLE_BUCKET_NAME =
"james-deleted-message-vault";
Review Comment:
I think using the term Bucket or bucket name for the blobstore was a
mistake. it overlaps in a bad way with the s3 notions.
Here you are manipulating a blobstore bucket.
I think this can be stored as a subpath of a single underlying S3 bucket by
using the prefix property on the S3 configuration
This is all very confusing (to me at least) as this prefix only allows to
shift the whole namespace in which case it is impossible to split storage of
some use cases among different bucket
On a more direct musing I think the previous design influences the naming
too much here, the term `single` will become confusing quite fast. I think I
would use DEFAULT_VAULT_BUCKET instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
