chibenwa commented on code in PR #2902:
URL: https://github.com/apache/james-project/pull/2902#discussion_r2698901534
##########
mailbox/plugin/deleted-messages-vault/src/main/java/org/apache/james/vault/VaultConfiguration.java:
##########
@@ -31,32 +31,38 @@
import com.google.common.base.Preconditions;
public class VaultConfiguration {
+ public static final String DEFAULT_SINGLE_BUCKET_NAME =
"james-deleted-message-vault";
Review Comment:
> I think using the term Bucket or bucket name for the blobstore was a
mistake.
+1
But as said CF previous refactoring that may not be something easy that we
are willing to change.
> I think this can be stored as a subpath of a single underlying S3 bucket
I don't want this to mess up with mailbox GC. I'd rather have a separate
blob store bucket if given the choice.
Also a separate blob store bucket makes loads of sense as the storage
constraints are not the standard james ones (glacier?)
> I think I would use DEFAULT_VAULT_BUCKET instead
Cf comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
