chibenwa commented on code in PR #3059:
URL: https://github.com/apache/james-project/pull/3059#discussion_r3404409898
##########
examples/custom-imap/sample-configuration/imapserver.xml:
##########
@@ -33,6 +33,13 @@ under the License.
<connectionLimitPerIP>0</connectionLimitPerIP>
<plainAuthDisallowed>false</plainAuthDisallowed>
<gracefulShutdown>false</gracefulShutdown>
+ <auth>
+
<saslMechanisms>PlainSaslMechanism,org.apache.james.examples.imap.sasl.ExampleTokenSaslMechanism</saslMechanisms>
Review Comment:
Wouldn't it be more straightforward to have the SaslMechanismFactory defined
here?
The protocol layer would use guice directly to instanciate the factory then
instanciate the mechanism: it would be a more straightforward design no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
