chibenwa commented on code in PR #3059: URL: https://github.com/apache/james-project/pull/3059#discussion_r3404440427
########## protocols/api/src/main/java/org/apache/james/protocols/api/sasl/OidcSaslMechanisms.java: ########## @@ -0,0 +1,70 @@ +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ + +package org.apache.james.protocols.api.sasl; + +import java.nio.charset.StandardCharsets; +import java.util.Optional; + +import org.apache.james.core.Username; +import org.apache.james.protocols.api.OIDCSASLParser; + +public final class OidcSaslMechanisms { + static SaslExchange start(Optional<byte[]> initialResponse) { + return new OidcSaslExchange(initialResponse); + } + + private OidcSaslMechanisms() { + } + + private static class OidcSaslExchange implements SaslExchange { + private final Optional<byte[]> initialResponse; + + private OidcSaslExchange(Optional<byte[]> initialResponse) { + this.initialResponse = initialResponse; + } + + @Override + public SaslStep firstStep() { + return initialResponse + .map(this::authenticate) + .orElseGet(() -> new SaslStep.Challenge(Optional.empty())); + } + + @Override + public SaslStep onResponse(byte[] clientResponse) { + return authenticate(clientResponse); + } + + @Override + public void abort() { + } + + @Override + public void close() { + } + + private SaslStep authenticate(byte[] clientResponse) { + return OIDCSASLParser.parseDecoded(new String(clientResponse, StandardCharsets.US_ASCII)) + .map(response -> (SaslStep) new SaslStep.Credentials(new SaslCredentials.BearerToken( + response.getToken(), Username.of(response.getAssociatedUser())))) Review Comment: So if I understand this correctly the Sasl layer do not perform the auth but provides the token handed over to the server. Each calling layer would need to handled each kind of credentials. That is not acceptable to me imo the athentication layer need to be embedded in the SASL layer so that we mutualize it and leverage a code / complexity reduction which is not the case here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
