chibenwa commented on code in PR #3194: URL: https://github.com/apache/james-project/pull/3194#discussion_r4084321894
########## server/queue/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueueFactory.java: ########## @@ -1,64 +1,58 @@ -/**************************************************************** - * Licensed to the Apache Software Foundation (ASF) under one * - * or more contributor license agreements. See the NOTICE file * - * distributed with this work for additional information * - * regarding copyright ownership. The ASF licenses this file * - * to you under the Apache License, Version 2.0 (the * - * "License"); you may not use this file except in compliance * - * with the License. You may obtain a copy of the License at * - * * - * http://www.apache.org/licenses/LICENSE-2.0 * - * * - * Unless required by applicable law or agreed to in writing, * - * software distributed under the License is distributed on an * - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * - * KIND, either express or implied. See the License for the * - * specific language governing permissions and limitations * - * under the License. * - ****************************************************************/ -package org.apache.james.queue.activemq; - -import jakarta.inject.Inject; -import jakarta.jms.ConnectionFactory; - -import org.apache.james.metrics.api.GaugeRegistry; -import org.apache.james.metrics.api.MetricFactory; -import org.apache.james.queue.activemq.metric.ActiveMQMetricCollector; -import org.apache.james.queue.api.MailQueueFactory; -import org.apache.james.queue.api.MailQueueItemDecoratorFactory; -import org.apache.james.queue.api.MailQueueName; -import org.apache.james.queue.api.ManageableMailQueue; -import org.apache.james.queue.jms.JMSMailQueueFactory; - -/** - * {@link MailQueueFactory} implementations which return - * {@link ActiveMQCacheableMailQueue} instances - */ -public class ActiveMQMailQueueFactory extends JMSMailQueueFactory { - - private boolean useBlob = true; - - private final ActiveMQMetricCollector activeMQMetricCollector; - - public ActiveMQMailQueueFactory(ConnectionFactory connectionFactory, MailQueueItemDecoratorFactory mailQueueItemDecoratorFactory, MetricFactory metricFactory, - GaugeRegistry gaugeRegistry, ActiveMQMetricCollector activeMQMetricCollector) { - super(connectionFactory, mailQueueItemDecoratorFactory, metricFactory, gaugeRegistry); - this.activeMQMetricCollector = activeMQMetricCollector; - } - - @Inject - public ActiveMQMailQueueFactory(EmbeddedActiveMQ embeddedActiveMQ, MailQueueItemDecoratorFactory mailQueueItemDecoratorFactory, MetricFactory metricFactory, - GaugeRegistry gaugeRegistry, ActiveMQMetricCollector activeMQMetricCollector) { - this(embeddedActiveMQ.getConnectionFactory(), mailQueueItemDecoratorFactory, metricFactory, gaugeRegistry, activeMQMetricCollector); - } - - public void setUseBlobMessages(boolean useBlob) { - this.useBlob = useBlob; - } - - @Override - protected ManageableMailQueue createCacheableMailQueue(MailQueueName name) { - activeMQMetricCollector.collectQueueStatistics(name); - return new ActiveMQCacheableMailQueue(connectionFactory, mailQueueItemDecoratorFactory, name, useBlob, metricFactory, gaugeRegistry); - } -} +/**************************************************************** + * Licensed to the Apache Software Foundation (ASF) under one * + * or more contributor license agreements. See the NOTICE file * + * distributed with this work for additional information * + * regarding copyright ownership. The ASF licenses this file * + * to you under the Apache License, Version 2.0 (the * + * "License"); you may not use this file except in compliance * + * with the License. You may obtain a copy of the License at * + * * + * http://www.apache.org/licenses/LICENSE-2.0 * + * * + * Unless required by applicable law or agreed to in writing, * + * software distributed under the License is distributed on an * + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * + * KIND, either express or implied. See the License for the * + * specific language governing permissions and limitations * + * under the License. * + ****************************************************************/ +package org.apache.james.queue.activemq; + +import jakarta.inject.Inject; +import jakarta.jms.ConnectionFactory; + +import org.apache.james.metrics.api.GaugeRegistry; +import org.apache.james.metrics.api.MetricFactory; +import org.apache.james.queue.activemq.metric.ActiveMQMetricCollector; +import org.apache.james.queue.api.MailQueueFactory; +import org.apache.james.queue.api.MailQueueItemDecoratorFactory; +import org.apache.james.queue.api.MailQueueName; +import org.apache.james.queue.api.ManageableMailQueue; +import org.apache.james.queue.jms.JMSMailQueueFactory; + +/** + * {@link MailQueueFactory} implementation which returns + * {@link ActiveMQCacheableMailQueue} instances backed by Apache ActiveMQ Artemis. + */ +public class ActiveMQMailQueueFactory extends JMSMailQueueFactory { Review Comment: Given we strip ActiveMQMetricCollector I believe we can then directly rely on JMSMailQueueFactory no ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
