prosgarz35 commented on PR #3194:
URL: https://github.com/apache/james-project/pull/3194#issuecomment-5806136070
Hi @chibenwa,
I have updated the PR to address all feedback:
1. **Netty exclusions in `pom.xml`**:
- Re-added the `<exclusions>` for `io.netty:*` on both
`artemis-jakarta-client` and `artemis-jakarta-server` in the root POM
`<dependencyManagement>` to keep Netty aligned.
- Cleaned up the redundant explicit version on
`artemis-jakarta-server` in `server/queue/queue-activemq/pom.xml`.
2. **Removed `ActiveMQCacheableMailQueue`**:
- Dropped the trivial wrapper class.
- Updated `ActiveMQMailQueueFactory` and tests to instantiate and use
`JMSCacheableMailQueue` directly.
3. **Removed `ActiveMQMetricCollectorImpl`**:
- Deleted the dead stub class since the legacy ActiveMQ Statistics
Plugin is not supported by Artemis.
- Retained `ActiveMQMetricCollectorNoop` as the default collector
implementation.
4. **Housekeeping**:
- Restored `.gitattributes` to the upstream baseline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
