prosgarz35 commented on PR #3194:
URL: https://github.com/apache/james-project/pull/3194#issuecomment-5810051635
### 1. `server/queue/queue-activemq/pom.xml` (Netty version alignment):
> Which netty version is pulled by artemis? Are we alligned? If not I
would recommend to keep this dependency management trick.
Yes, they are now 100% aligned! Apache Artemis 2.56.0 pulls in Netty
4.1.x. In our previous commit, we imported
`io.netty:netty-bom:${netty.version}` into `<dependencyManagement>` in the root
`pom.xml`. As verified by `mvn
dependency:tree`, all Netty dependencies across the reactor (including
`artemis-server` and `artemis-jakarta-server`) are strictly governed and
resolved to `${netty.version}` (`4.1.135.Final`). Thus, explicit per-module
dependency
management workarounds for `netty-transport` are no longer required.
---
### 2. `pom.xml` (`useNativeGit`):
> Unrelated to your changes. Windows support I presume. I'd rather have
a os based env var to disable this if you do not mind.
Done. We restored `<useNativeGit>${git.useNativeGit}</useNativeGit>`
with `<git.useNativeGit>true</git.useNativeGit>` by default (preserving native
git on Linux/CI environments). In addition, we added an OS-activated Maven
profile
(`windows-git`) that activates on `<family>windows</family>` and sets
`<git.useNativeGit>false</git.useNativeGit>`.
---
### 3. `server/queue/queue-jms/.../JMSCacheableMailQueue.java` (Property
name encoding/decoding):
> This needs a dedicated test suite IMO
Added a dedicated unit test suite:
`JMSCacheableMailQueuePropertyNameTest`.
It thoroughly covers:
- Attribute property name encoding (`JAMES_ATTR_` prefix, preserving
legal Java identifier characters, hex-encoding dots, hyphens, and spaces).
- Per-recipient header property name encoding
(`JAMES_MAIL_PER_RECIPIENT_HEADERS_` prefix, hex-encoding email characters like
`@`, `.`, `+`, `-`).
- Robustness and error tolerance in decoding (handling regular
underscores, malformed hex, short tokens).
- Parameterized round-trip encode-and-decode verification across varied
recipient addresses conforming to RFC 5322.
- Validation that generated names strictly adhere to JMS identifier
specifications (`Character.isJavaIdentifierPart`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
