prosgarz35 commented on code in PR #3223:
URL: https://github.com/apache/james-project/pull/3223#discussion_r4165440199
##########
server/protocols/jwt/src/main/java/org/apache/james/jwt/PublicKeyReader.java:
##########
@@ -46,7 +58,13 @@ private Optional<PublicKey> publicKeyFrom(PEMParser reader) {
return Optional.of(new
JcaPEMKeyConverter().getPublicKey((SubjectPublicKeyInfo) readPEM));
}
if (readPEM instanceof X509CertificateHolder) {
- SubjectPublicKeyInfo keyInfo = ((X509CertificateHolder)
readPEM).getSubjectPublicKeyInfo();
+ X509CertificateHolder certHolder = (X509CertificateHolder)
readPEM;
+ Date now = Date.from(clock.instant());
+ if (now.before(certHolder.getNotBefore()) ||
now.after(certHolder.getNotAfter())) {
+ LOGGER.warn("Certificate is not valid at {}. Validity: [{}
- {}]",
+ now, certHolder.getNotBefore(),
certHolder.getNotAfter());
+ }
Review Comment:
I can say why - example there russian certs which dont counts as safe for
all browser and other programmes but under sanctions some companies cant issue
lets encryp and other acme certificates - only self sigh or this national
certificates... And this option seems needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
